Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added NOAA CSPs to allowable hosts. #1714

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Added NOAA CSPs to allowable hosts. #1714

merged 1 commit into from
Jun 26, 2023

Conversation

HenryRWinterbottom
Copy link
Contributor

Description

This PR addresses issue #1713.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

The execution time environment for workflow/setup_expt.py has been tested and the correct NOAA CSP platform is specified. Note that this has only been tested for NOAA CSP AWS as global-workflow is not yet supported on the other CSPs.
-->

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

aerorahul
aerorahul approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@aerorahul aerorahul merged commit 524c713 into NOAA-EMC:develop Jun 26, 2023
@aerorahul aerorahul mentioned this pull request Jun 26, 2023
Closed
@HenryRWinterbottom HenryRWinterbottom deleted the feature/noaa_csp_host_detect branch July 5, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerorahul aerorahul aerorahul approved these changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA Awaiting requested review from WalterKolczynski-NOAA WalterKolczynski-NOAA is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HenryRWinterbottom @aerorahul